Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop main() functions from all gtest files #245

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Drop main() functions from all gtest files #245

merged 1 commit into from
Apr 4, 2022

Conversation

mjcarroll
Copy link
Contributor

Signed-off-by: Michael Carroll michael@openrobotics.org

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll self-assigned this Apr 1, 2022
@mjcarroll mjcarroll requested a review from nkoenig as a code owner April 1, 2022 16:21
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 1, 2022
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #245 (860b027) into main (ff89488) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   75.54%   75.54%           
=======================================
  Files          20       20           
  Lines        2850     2850           
=======================================
  Hits         2153     2153           
  Misses        697      697           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff89488...860b027. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we have more failures on Windows, but I don't think they're related to this PR?

@mjcarroll
Copy link
Contributor Author

but I don't think they're related to this PR?

I don't believe so, I opened a tracking ticket a little while back #231

@mjcarroll mjcarroll merged commit bd50422 into main Apr 4, 2022
@mjcarroll mjcarroll deleted the drop_main branch April 4, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants