4 ➡️ 5 #193
Merged
4 ➡️ 5 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed donwload on Windows Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed interface_TEST Signed-off-by: ahcorde <ahcorde@gmail.com> * Improved windows support Signed-off-by: ahcorde <ahcorde@gmail.com> * Make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Improved Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed test on Windows Signed-off-by: Alejandro Hernández <ahcorde@gmail.com> * Fixed test Signed-off-by: ahcorde <ahcorde@gmail.com> * Fix some nits Signed-off-by: ahcorde <ahcorde@gmail.com> * Improved Windows support Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed test on Linux Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed windows tests Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed tests Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feddback Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools5 #193 +/- ##
===================================================
- Coverage 77.53% 75.60% -1.93%
===================================================
Files 19 19
Lines 2657 2742 +85
===================================================
+ Hits 2060 2073 +13
- Misses 597 669 +72
Continue to review full report at Codecov.
|
|
@osrf-jenkins retest this please |
1 similar comment
|
@osrf-jenkins retest this please |
ahcorde
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-fuel-tools4toign-fuel-tools5.Branch comparison: ign-fuel-tools5...ign-fuel-tools4
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸