Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-triage tickets to core board #89

Merged
merged 1 commit into from
May 1, 2020
Merged

Auto-triage tickets to core board #89

merged 1 commit into from
May 1, 2020

Conversation

chapulina
Copy link
Contributor

Uses this action: https://github.com/technote-space/create-project-card-action/tree/v1

Tickets are triaged by the @osrf-triage account, see the examples:

It looks like the action is triggered for all issues as long as it's in the master branch.

But for PRs, it needs to be in the PR branch. See how the action didn't run for this PR: gazebosim/testing#4

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@j-rivero
Copy link
Contributor

j-rivero commented May 1, 2020

@osrf-jenkins run tests

@j-rivero
Copy link
Contributor

j-rivero commented May 1, 2020

But for PRs, it needs to be in the PR branch. See how the action didn't run for this PR: ignitionrobotics/testing#4

This means that the code needs to previously in the master branch? If that is the case I would say that is expected. If it does mean that the action needs to be among the code changed by a PR then it seems weird to me.

@j-rivero j-rivero self-requested a review May 1, 2020 15:00
@chapulina
Copy link
Contributor Author

This means that the code needs to previously in the master branch?

I believe it needs to be in the branch that's making the PR. So we should add the action to all release branches + master, which are expected to be used as base branches for PRs.

@chapulina chapulina merged commit 80df6ae into master May 1, 2020
@chapulina chapulina deleted the triage_action branch May 1, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants