Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of FindYAML.cmake and FindJSONCPP without pkg-config #79

Merged
merged 3 commits into from
Apr 30, 2020
Merged

Fix use of FindYAML.cmake and FindJSONCPP without pkg-config #79

merged 3 commits into from
Apr 30, 2020

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Apr 27, 2020 •
edited
Loading

In particular, fix their use if the corresponding CMake config file is not found, and at the same time pkg-config is not found in the system.

Related fix:

@scpeters

@traversaro
Fix use of FindYAML.cmake without pkg-config
d15f2ef 
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
@traversaro
FindJSONCPP: Fix use without pkg-config if no CMake config is present
0d6fdb4 
Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
@scpeters scpeters self-requested a review April 27, 2020 18:48
@scpeters scpeters mentioned this pull request Apr 28, 2020
Merged
@scpeters scpeters requested a review from mxgrey as a code owner April 28, 2020 15:30
mxgrey
mxgrey approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@scpeters scpeters merged commit 2f5c317 into gazebosim:ign-cmake2 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxgrey mxgrey mxgrey approved these changes

@scpeters scpeters scpeters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@traversaro @mxgrey @scpeters