Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect if comparison in build_examples #356

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Jun 14, 2023

🦟 Bug fix

Summary

Introduced in #354

While I tested this with my local Windows machine, the buildfarm seems to be slightly different yielding an error.

CMake Error at C:/J/workspace/ign_common-pr-win/ws/install/gz-cmake3/share/cmake/gz-cmake3/cmake3/GzBuildExamples.cmake:54 (if):
  if given arguments:

    "C:\\J\\workspace\\ign_common-pr-win\\ws\\install\\gz-math7" "C:\\J\\workspace\\ign_common-pr-win\\ws\\install\\gz-utils2" "C:\\J\\workspace\\ign_common-pr-win\\ws\\install\\gz-cmake3"

  Unknown arguments specified
Call Stack (most recent call first):
  CMakeLists.txt:164 (gz_build_examples)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Jun 14, 2023
@mjcarroll mjcarroll merged commit 3112b86 into gz-cmake3 Jun 14, 2023
@mjcarroll mjcarroll deleted the mjcarroll/fix_if_statement branch June 14, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants