Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for gz-cmake2 2.17.0 release #351

Merged
merged 3 commits into from
May 22, 2023
Merged

Conversation

j-rivero
Copy link
Contributor

🎈 Release

Preparation for 2.17.0 release.

Comparison to 2.16.0: https://github.com/gazebosim/gz-cmake/compare/ignition-cmake2_2.16.0...jrivero/gz_cmake_2_17_0?expand=1

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

j-rivero added 2 commits May 19, 2023 19:57
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero requested review from mxgrey and scpeters as code owners May 19, 2023 18:01
@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels May 19, 2023
Changelog.md Outdated
* [Pull request #338](https://github.com/gazebosim/ign-cmake/pull/338)

1. Disable protobuf warnings on protobuf target (#335)
* [Pull request #335) (#336](https://github.com/gazebosim/ign-cmake/pull/335) (#336)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just this?

* [Pull request #335](https://github.com/gazebosim/ign-cmake/pull/335)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch thanks! 447cb3d

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero merged commit 940e2b7 into ign-cmake2 May 22, 2023
@j-rivero j-rivero deleted the jrivero/gz_cmake_2_17_0 branch May 22, 2023 09:45
j-rivero added a commit that referenced this pull request Jul 11, 2023
* Use CONFIG in gz_add_benchmark to avoid Windows collisions (#341)

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>

* Prepare for gz-cmake2 2.17.0 release (#351)

* Bump version to 2.17.0
* Update Changelog
---------

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>

---------

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants