Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload docs to an s3 bucket based only on the major version #281

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 20, 2022

Signed-off-by: Nate Koenig nate@openrobotics.org

🎉 New feature

Closes #

Summary

This changes the upload_doc.sh script so that API documentation is uploaded to a directory based only on the major version. This will make it easier to find, maintain, and link to the API documentation.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jul 20, 2022
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@chapulina chapulina added the documentation Improvements or additions to documentation label Jul 20, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkoenig nkoenig merged commit 344fa17 into ign-cmake2 Jul 20, 2022
@nkoenig nkoenig deleted the doc-major-only branch July 20, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel documentation Improvements or additions to documentation 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants