Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scpeters as code owner #261

Merged
merged 1 commit into from
May 24, 2022
Merged

Add scpeters as code owner #261

merged 1 commit into from
May 24, 2022
+1 −1

Conversation

scpeters
Copy link
Member

🎉 New feature

Helping fill in for @j-rivero while he is away

Summary

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Add scpeters as code owner
33c6530 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested review from mxgrey and j-rivero as code owners May 23, 2022 18:24
@scpeters scpeters requested a review from chapulina May 23, 2022 18:24
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels May 23, 2022
@scpeters scpeters merged commit 37d6070 into ign-cmake2 May 24, 2022
@scpeters scpeters deleted the scpeters/codeowner branch May 24, 2022 00:24
harshmahesheka pushed a commit to harshmahesheka/ign-cmake that referenced this pull request May 24, 2022
@scpeters @harshmahesheka
Add scpeters as code owner (gazebosim#261)
2811dc4 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @chapulina