Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MIGRATION file #242

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Rename MIGRATION file #242

merged 1 commit into from
Apr 25, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

The issue was introduced in #233. I was surprised to see that CI passed on that PR...

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina
Rename MIGRATION file
5a170b0 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from scpeters April 25, 2022 19:36
@chapulina chapulina mentioned this pull request Apr 25, 2022
Closed
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 25, 2022
@chapulina chapulina linked an issue Apr 25, 2022 that may be closed by this pull request
MIGRATION.md and Migration.md cause problems on non-case-sensitive filesystems #241
Closed
@scpeters scpeters merged commit 33492e4 into main Apr 25, 2022
@scpeters scpeters deleted the chapulina/migration branch April 25, 2022 20:14
@chapulina chapulina mentioned this pull request May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MIGRATION.md and Migration.md cause problems on non-case-sensitive filesystems
2 participants
@chapulina @scpeters