Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove adlarkin as ign-cmake codeowner #237

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Apr 18, 2022

Signed-off-by: Ashton Larkin 42042756+adlarkin@users.noreply.github.com

Summary

Removing myself as a codeowner of ign-cmake 😢

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@adlarkin adlarkin requested a review from chapulina April 18, 2022 19:33
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Apr 18, 2022
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@adlarkin adlarkin merged commit 7a88c1c into ign-cmake2 Apr 18, 2022
@adlarkin adlarkin deleted the adlarkin/remove_codeowner branch April 18, 2022 23:39
j-rivero pushed a commit that referenced this pull request Apr 19, 2022
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
harshmahesheka pushed a commit to harshmahesheka/ign-cmake that referenced this pull request May 24, 2022
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants