Allow to recreate targets created by IgnPkgConfig #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
8 tasks
adlarkin
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Looks okay to me. Hopefully this helps unblock gazebosim/gz-rendering#605.
|
@osrf-jenkins run tests please |
|
run another rebuild to Citadel. It built. Merging. |
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1 |
harshmahesheka
pushed a commit
to harshmahesheka/ign-cmake
that referenced
this pull request
May 24, 2022
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
There are problems when we call
ign_find_packagetwice related to the recreation of a CMake target already created byign_pkg_check_modules_*methods. The PR removes the check that avoid this option.See gazebosim/gz-rendering#605 for an use case related to this limitation.
I've tested this with a fortress workspace on Focal and everything seems to built. It might be software affected out there but having the ability of calling a
ign_find_packagetwice and recreate an CMake TARGET with updated information seems to me the way to go.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.