Adding CONFIG option

[harshmahesheka]

This is a PR with regards to the issue #114 .

[adlarkin]

Thanks for the contribution, this looks good to me! @scpeters and/or @j-rivero, would you mind taking a look at this as well? I'm also wondering if we will need to update downstream libraries (such as ign-physics based on what I read in #114) once this is merged.

[j-rivero]

The PR looks mostly fine to me. It would be great if we can test it in combination with ign-physics following the initial use case.

Before merging, I would appreciate to have a test in place for this new feature.

[harshmahesheka]

The PR looks mostly fine to me. It would be great if we can test it in combination with ign-physics following the initial use case.

Before merging, I would appreciate to have a test in place for this new feature.

Hey @j-rivero , what kind of tests would be required, could you guide me with some previous examples?

[j-rivero]

The PR looks mostly fine to me. It would be great if we can test it in combination with ign-physics following the initial use case.
Before merging, I would appreciate to have a test in place for this new feature.

Hey @j-rivero , what kind of tests would be required, could you guide me with some previous examples?

Sorry for not providing some pointers. I see at least two alternatives:

• The cool one: create a test case under the https://github.com/ignitionrobotics/ign-cmake/tree/ign-cmake2/examples (the core_child inspection can provide hints about how examples are implemented) that hosts a CMake project/module that uses CONFIG and the top level CMakeLists.txt call it with something like ign_find_package(ignition-find_config CONFIG REQUIRED).
• A manual example: not so nice, but you could just copy what we are doing for ogre2 https://github.com/ignitionrobotics/ign-cmake/tree/ign-cmake2/examples/find_ogre2 and create one for DART using the CONFIG new argument.

[adlarkin]

@j-rivero I opened a PR in ign-physics that makes use of this PR if you want to take a look: gazebosim/gz-physics#339

@harshmahesheka, other than the testing comments mentioned above, I left one last minor comment if you wouldn't mind addressing it before we merge this.

[harshmahesheka]

Hey @adlarkin, sorry for missing it. I have merged the suggested changes.

[adlarkin]

@harshmahesheka we are going to merge this PR now since a few other PRs depend on it, but if you still want to add tests, feel free to do that in a separate PR. Thanks for the contribution!

[osrf-triage]

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1