Add LEGACY_PROJECT_PREFIX option #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cmake config template file currently creates legacy cmake variables with capital letters like IGNITION-MATH_LIBRARIES and IGNITION-MATH_INCLUDE_DIRS. Since sdformat uses inconsistent case in the legacy cmake variables, like SDFormat_LIBRARIES, the prefix for these variables is made configurable as LEGACY_PROJECT_PREFIX in the ign_create_core_library function. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to gazebosim/sdformat
that referenced
this pull request
Dec 19, 2021
Requires gazebosim/gz-cmake#199 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
adlarkin
approved these changes
Dec 20, 2021
There was a problem hiding this comment.
Changes look good, and I had no issues when testing with gazebosim/sdformat@e987976. I just left one very minor comment
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
actions CI failing due to docker hub issue: |
docker is working again; CI is clean, so I will merge |
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
srmainwaring
pushed a commit
to srmainwaring/gz-cmake
that referenced
this pull request
Mar 1, 2022
The cmake config template file currently creates legacy cmake variables with capital letters like IGNITION-MATH_LIBRARIES and IGNITION-MATH_INCLUDE_DIRS. Since sdformat uses inconsistent case in the legacy cmake variables, like SDFormat_LIBRARIES, the prefix for these variables is made configurable as LEGACY_PROJECT_PREFIX in the ign_create_core_library function. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Needed by gazebosim/sdformat#780
Summary
The cmake config template file currently creates legacy cmake variables with capital letters like
IGNITION-MATH_LIBRARIESandIGNITION-MATH_INCLUDE_DIRS. In order to support a project with inconsistent case in the legacy cmake variables, likeSDFormat_LIBRARIES, the prefix for these variables is made configurable asLEGACY_PROJECT_PREFIXin theign_create_core_libraryfunction.Test it
Compile against gazebosim/sdformat@e987976
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.