Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doxygen allow all .cc .hh and CMakeLists.txt files #198

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

mabelzhang
Copy link
Contributor

🦟 Bug fix

Followup of gazebosim/gz-physics#312
See gazebosim/gz-physics#312 (comment) and gazebosim/gz-physics#312 (comment)

Summary

Some of our tutorials reference snippets in files not in the examples directory, which currently is the only place we allow snippets from. This PR extends the wildcard to allow all .hh, .cc, and adds CMakeLists.txt files.

Will open PR in ign-physics to demonstrate this.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@mabelzhang mabelzhang requested a review from azeey December 18, 2021 05:38
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Dec 18, 2021
@chapulina chapulina added the documentation Improvements or additions to documentation label Dec 20, 2021
@mabelzhang mabelzhang merged commit 595a155 into ign-cmake2 Dec 21, 2021
@mabelzhang mabelzhang deleted the mabelzhang/add_doxyge_filters branch December 21, 2021 04:08
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

srmainwaring pushed a commit to srmainwaring/gz-cmake that referenced this pull request Mar 1, 2022
…ir (gazebosim#198)

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel documentation Improvements or additions to documentation 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants