Fix include directory flags for codecheck #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
8 tasks
mjcarroll
reviewed
Sep 1, 2021
mjcarroll
approved these changes
Sep 1, 2021
srmainwaring
pushed a commit
to srmainwaring/gz-cmake
that referenced
this pull request
Mar 1, 2022
The include directories of cppcheck need individual -I flags ahead of each directory. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The include directories of
cppcheckneed individual-Iflags head of each directory. This helps get rid of false-positives in my testing on sdformat. I've ran codecheck on other ignition libraries using this patch and it doesn't seem to cause any regressions.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge