Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another try at OGRE2.1/OGRE2.2 on Windows #177

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Aug 13, 2021

This provides logic for OGRE2.1 and OGRE2.2 packages from https://github.com/osrf/vcpkg-ports

Originally, we were relying on the cmake find_package mechanism, but if OGRE1.x and OGRE2.x are both installed via vcpkg, there are issues with the cmake logic.

This eliminates all of the cmake logic that comes with OGRE2 and reimplements it locally to find plugins and components that are relevant to ignition development.

Signed-off-by: Michael Carroll michael@openrobotics.org

@mjcarroll mjcarroll requested a review from ahcorde August 13, 2021 16:47
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Aug 13, 2021
@mjcarroll mjcarroll marked this pull request as ready for review August 13, 2021 20:38
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to compile ign-rendering6 with Ogre2.2 with this PR, but I'm not able to run any of the examples, it's failing in the dlopen in this method Loader::Implementation::LoadLib.

DCO ?

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll merged commit 33908b1 into ign-cmake2 Aug 16, 2021
@mjcarroll mjcarroll deleted the ogre22_win_again branch August 16, 2021 15:42
@chapulina
Copy link
Contributor

I think this broke our Windows CI: https://build.osrfoundation.org/job/ign_gazebo-ci-win/120/console

CMake Error in ogre2/src/CMakeLists.txt:
  Imported target "IgnOGRE2::IgnOGRE2" includes non-existent path

    "C:/vcpkg/installed/x64-windows/debug/include/OGRE-2.1"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

@chapulina chapulina added the Windows Windows support label Aug 17, 2021
@mjcarroll
Copy link
Contributor Author

Ah, pulling a Windows machine out of CI to test this afternoon.

mjcarroll added a commit that referenced this pull request Aug 19, 2021
chapulina pushed a commit that referenced this pull request Aug 19, 2021
This reverts commit 33908b1.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
srmainwaring pushed a commit to srmainwaring/gz-cmake that referenced this pull request Mar 1, 2022
Signed-off-by: Michael Carroll <michael@openrobotics.org>
srmainwaring pushed a commit to srmainwaring/gz-cmake that referenced this pull request Mar 1, 2022
…azebosim#178)

This reverts commit 33908b1.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants