Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support imported targets in FindIgnOGRE.cmake #150

Merged
merged 4 commits into from
Feb 25, 2021
Merged

Support imported targets in FindIgnOGRE.cmake #150

merged 4 commits into from
Feb 25, 2021

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Feb 7, 2021 •
edited
Loading

Bug Report

Summary

Currently, if FindOGRE.cmake returns an imported target (like OGRE::OgreMain), the FindIgnOGRE module appends a .lib suffix to it, which is obviously wrong.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See
    contributing)
  • All tests passed (See
    test coverage)
  • While waiting for a review on your PR, please help review
    another open pull request
    to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@peci1
Support imported targets in FindIgnOGRE.cmake
2cd387b 
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
@peci1 peci1 requested a review from mxgrey as a code owner February 7, 2021 17:21
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Feb 7, 2021
@chapulina chapulina requested a review from nkoenig February 8, 2021 19:20
@adlarkin adlarkin requested a review from j-rivero as a code owner February 12, 2021 18:54
j-rivero
j-rivero approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One minor suggestion to comment the change and we are good to go.

@peci1 @j-rivero
FindIgnOGRE: update comment
6f131cb 
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>

Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@peci1 peci1 requested a review from adlarkin as a code owner February 22, 2021 19:39
@peci1
Copy link
Contributor Author

peci1 commented Feb 22, 2021

Thanks, comment added.

@adlarkin
Copy link
Contributor

There was a warning on Homebrew CI that should have been fixed by gazebo-tooling/release-tools#401. I have re-triggered Homebrew CI to make sure it comes back green.

@adlarkin adlarkin merged commit f907b0b into gazebosim:ign-cmake2 Feb 25, 2021
@adlarkin adlarkin mentioned this pull request Feb 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

@adlarkin adlarkin adlarkin approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@nkoenig nkoenig Awaiting requested review from nkoenig

Assignees
No one assigned
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peci1 @adlarkin @j-rivero