Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CMake's CMP0079 policy #146

Merged
merged 3 commits into from
Jan 16, 2021
Merged

Set CMake's CMP0079 policy #146

merged 3 commits into from
Jan 16, 2021

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Jan 13, 2021

Explicitly opt into the new behavior.

For more information on the CMP0079 policy, see CMake's documentation

Fixes #88

Signed-off-by: Michael Carroll michael@openrobotics.org

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll self-assigned this Jan 13, 2021
@mjcarroll mjcarroll requested a review from mxgrey as a code owner January 13, 2021 15:27
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Jan 13, 2021
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@adlarkin adlarkin self-requested a review January 13, 2021 15:38
@mjcarroll
Copy link
Contributor Author

CC: @traversaro. Do you see any reason not to opt into the new behavior? I have been using it for a bit with no issue on my focal machine.

Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like 76 is being used instead of 79, but once that's fixed, this looks good to me!

Signed-off-by: Michael Carroll <michael@openrobotics.org>

Co-authored-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@traversaro
Copy link
Contributor

CC: @traversaro. Do you see any reason not to opt into the new behavior? I have been using it for a bit with no issue on my focal machine.

Yes, I think it should be harmless to switch to the new policy settings.

@chapulina chapulina merged commit bed3f7b into ign-cmake2 Jan 16, 2021
@chapulina chapulina deleted the set_cmp0079 branch January 16, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake policy CMP0079 warning
5 participants