Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the Ignition repositories are transitioning towards instructing users to use a repository's
*packages.apt
files to install build dependencies (for example, ign-gazebo). In case users want to install all of the Ignition build dependencies in a single pass via a command like this, we should make sure things likecmake
(andmake
) get installed so that users have no issues when usingign-cmake
.I also added in
build-essential
because this will guarantee thatgcc
,g++
, andmake
are installed on Ubuntu Bionic and Focal - this is important in case users decided to use the--no-install-recommends
flag when installing packages listed in the*packages.apt
files (I ran a test with theubuntu:focal
Docker image and noticed thatmake
wasn't installed even after installing all Ignition Binaries and other packages in Ignition's*packages.apt
files. Includingbuild-essential
fixed this for me):Signed-off-by: Ashton Larkin ashton@openrobotics.org