Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages.apt #130

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Update packages.apt #130

merged 1 commit into from
Dec 4, 2020

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Dec 3, 2020

A lot of the Ignition repositories are transitioning towards instructing users to use a repository's *packages.apt files to install build dependencies (for example, ign-gazebo). In case users want to install all of the Ignition build dependencies in a single pass via a command like this, we should make sure things like cmake (and make) get installed so that users have no issues when using ign-cmake.

I also added in build-essential because this will guarantee that gcc, g++, and make are installed on Ubuntu Bionic and Focal - this is important in case users decided to use the --no-install-recommends flag when installing packages listed in the *packages.apt files (I ran a test with the ubuntu:focal Docker image and noticed that make wasn't installed even after installing all Ignition Binaries and other packages in Ignition's *packages.apt files. Including build-essential fixed this for me):

adl-ws@96bdcbfc1916:~/ws$ apt-cache depends build-essential
build-essential
 |Depends: libc6-dev
  Depends: <libc-dev>
    libc6-dev
  Depends: gcc
  Depends: g++
  Depends: make
    make-guile
  Depends: dpkg-dev

Signed-off-by: Ashton Larkin ashton@openrobotics.org

@adlarkin adlarkin requested a review from mjcarroll December 3, 2020 16:13
@adlarkin adlarkin requested a review from mxgrey as a code owner December 3, 2020 16:13
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Dec 3, 2020
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@adlarkin adlarkin force-pushed the adlarkin/update_packages.apt branch from 0e56b4f to e77122d Compare December 4, 2020 16:37
@adlarkin adlarkin merged commit e77122d into ign-cmake2 Dec 4, 2020
@adlarkin adlarkin deleted the adlarkin/update_packages.apt branch December 4, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants