-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FindUUID: Always define UUID::UUID on Apple platforms #128
Conversation
Backport of gazebosim/gz-cmake#128 Fix of the problems reported in conda-forge/libuuid-feedstock#16 for Ignition libraries.
diff without whitespace: https://github.com/ignitionrobotics/ign-cmake/pull/128/files?w=1 |
this looks reasonable to me; I'd just like to test it with a larger set of packages before approving |
Thanks, I don't have currently a macOS box to test, so any additional test is welcome. |
I actually was able to propagate the change in conda and test it in https://github.com/robotology/robotology-superbuild/pull/513/https://github.com/robotology/robotology-superbuild/pull/513/checks?check_run_id=1414508924, and I found another problem: the target should only be defined if no target with the same name is already defined, otherwise if you call twice
I fixed the problem in the latest version of the PR. |
On Apple platforms, the headers of libuuid and its symbols are provided by the OS SDK, so no further linking is necessary. Fix gazebosim#127 Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
sorry for the delayed review; this looks good. I suppose we can stop depending on the |
On Apple platforms, the headers of libuuid and its symbols are provided by the OS SDK, so no further linking is necessary.
Fix #127
Signed-off-by: Silvio Traversaro silvio.traversaro@iit.it