This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
Distortion/LensFlarePlugin: set compositor names #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the ConnectionPtr and SubscriberPtr are last. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This can be used to set the pixel format of textures for example. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Read the compositor name from a custom element <ignition:compositor />. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
|
the homebrew build is failing due to osrf/homebrew-simulation#1477 / #2867 |
scpeters
reviewed
May 21, 2021
There was a problem hiding this comment.
this looks great overall; I just added a few minor comments related to code style. Some of them may have been caught by sh tools/code_check.sh (run from the root of the repository), but there are so many existing failures, that it can be hard to identify new errors, so I wouldn't require you to do that
|
I expect the homebrew build will fail again until gazebo-tooling/release-tools#465 is merged |
Signed-off-by: Audrow Nash <audrow@hey.com>
scpeters
approved these changes
May 25, 2021
|
I think the homebrew CI will work now, so I pushed a small fix to a test that has been failing for a long time to restart CI. |
It gives more feedback on failure than QVERIFY. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This has been broken since we added the expressed_in field to joint.proto Signed-off-by: Steve Peters <scpeters@openrobotics.org>
WilliamLewww
approved these changes
May 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3005 by taking the second approach suggested.