Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI interactions #2

Merged
merged 12 commits into from
Jun 5, 2020
Merged

GUI interactions #2

merged 12 commits into from
Jun 5, 2020

Conversation

chapulina
Copy link
Contributor

Initial draft for early feedback.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from nkoenig March 20, 2020 02:12
@JShep1
Copy link

JShep1 commented Mar 20, 2020

I did a sweep through and found a few typos. Looks good, let me know what I could add or fill in.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

I did a sweep through and found a few typos.

Thanks, @JShep1 ! Feel free to directly commit the typo fixes.

Looks good, let me know what I could add or fill in.

This is meant to be a collaborative effort, so if you feel inclined to add any references, user stories, fill any TODOs, or add missing features, feel free to commit directly. Just don't force push 😅

If there are ideas you have but you're not sure about, feel free to leave a comment here to start the conversation, or just ask me directly.

Thanks!

chapulina added 2 commits May 14, 2020 14:36
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina added 3 commits May 18, 2020 13:45
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina marked this pull request as ready for review May 21, 2020 02:26
chapulina added 2 commits May 29, 2020 18:09
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

Thanks everyone for all the feedback! I addressed all of it and ticketed issues for most features. I'm going to get this in and we can improve it over time.

@chapulina chapulina merged commit fee29f3 into master Jun 5, 2020
@chapulina chapulina deleted the gui_interactions branch June 5, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants