Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a GitHub action to install a Gazebo release in an appropriate linux distribution #3

Merged
merged 24 commits into from
Jun 4, 2024
Merged

Adding a GitHub action to install a Gazebo release in an appropriate linux distribution #3

merged 24 commits into from
Jun 4, 2024

Conversation

sauk2
Copy link
Collaborator

@sauk2 sauk2 commented Jun 1, 2024 •
edited
Loading

Summary

This PR is related to Issue #1. It creates a GitHub action to install a Gazebo release inside an Ubuntu distribution.

test.yml file tests this workflow by creating multiple runners with an appropriate Gazebo + Ubuntu combination, shown below.

      # Gazebo Citadel (Dec 2019 - Dec 2024)
      - docker_image: ubuntu:focal
        gazebo_distribution: citadel
  
  
      # Gazebo Fortress (Sep 2021 - Sep 2026)
      - docker_image: ubuntu:focal
        gazebo_distribution: fortress
  
  
      # Gazebo Garden (Sep 2022 - Nov 2024)
      - docker_image: ubuntu:focal
        gazebo_distribution: garden
  
  
      # Gazebo Harmonic (Sep 2023 - Sep 2028)
      - docker_image: ubuntu:jammy
        gazebo_distribution: harmonic

This workflow is set to run using the workflow_dispatch trigger. Testing this workflow will need the merge of PR #4 into main first (see PR for more details)

sauk2 added 8 commits June 1, 2024 13:16
@sauk2
Adding gazebo key and testing garden installation
0c3bb4b 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Built package to update index.js
65378fb 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Changed gpg key filepath
1b8726c 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Updated dist
b90cfdf 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Changed method to get gpg key
a0aef20 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Added no cert check in wget of gazebo gpg key
ca92b71 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Missing backslashes
d03611c 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Changed to a non interactive install command
1996322 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2 sauk2 changed the title Adding a GitHub action to install a Gazebo release in an appropriate linus distributuon Adding a GitHub action to install a Gazebo release in an appropriate linux distributuon Jun 1, 2024
sauk2 added 9 commits June 2, 2024 01:29
@sauk2
Added gz distro input functionality
56dd9f6 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Installing gz distro from user input
02de3a4 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Added exception in case no gz distro is specified
fa6e479 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Updated test workflow with inputs
ce3973a 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Updated test workflow with multiple cases
1c7d499 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Resolved job errors
9290cea 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Changed images for harmonic and garden in test workflow
41fcded 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Changed job names for better visibility
edd283c 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Changed testing to use matrix combinations
aef0570 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2 sauk2 mentioned this pull request Jun 2, 2024
Merged
@sauk2 sauk2 marked this pull request as ready for review June 2, 2024 05:39
@sauk2 sauk2 requested a review from j-rivero June 2, 2024 05:39
@j-rivero
Copy link
Contributor

j-rivero commented Jun 3, 2024

After merging #4, could you please rebase or merge the master branch of this repository in this branch?

j-rivero
j-rivero reviewed Jun 3, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
sauk2 added 3 commits June 3, 2024 20:19
@sauk2
Changed the test command to run in a single line
d273ff5 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Merge branch 'main' into feat/linux-setup
0162761 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Added default value to action input to prevent warning
1e3888d 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Copy link
Collaborator Author

sauk2 commented Jun 3, 2024

After merging #4, could you please rebase or merge the master branch of this repository in this branch?

I have merged the main of this repository into this branch

@sauk2 sauk2 requested a review from j-rivero June 3, 2024 12:37
j-rivero
j-rivero requested changes Jun 3, 2024
View reviewed changes
src/setup-gazebo-linux.ts Outdated Show resolved Hide resolved
src/setup-gazebo-linux.ts Outdated Show resolved Hide resolved
src/utils.ts Show resolved Hide resolved
@sauk2
Fixed indentation. Added ca certificate check while getting gz key
084ee97 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2 sauk2 requested a review from j-rivero June 3, 2024 15:51
j-rivero
j-rivero requested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the github action configurations should make this PR complete.

.github/workflows/test.yml Outdated Show resolved Hide resolved
@sauk2
Configured workflow to run on PRs/push
e525dc3 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2 sauk2 requested a review from j-rivero June 4, 2024 12:57
j-rivero
j-rivero approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing about a ROS environment variable. Good to do.

src/package_manager/apt.ts Outdated Show resolved Hide resolved
@sauk2
Removed ROS related variable in apt install script
66b9d4b 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2
Copy link
Collaborator Author

sauk2 commented Jun 4, 2024

Minor thing about a ROS environment variable. Good to do.

Somehow the action seems to be failing now. I am going though the error right now. Let me know if you have any idea about it.

@sauk2
Installing ca certificates to resolve wget error
f469121 
Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2 sauk2 changed the title Adding a GitHub action to install a Gazebo release in an appropriate linux distributuon Adding a GitHub action to install a Gazebo release in an appropriate linux distribution Jun 4, 2024
@sauk2
Copy link
Collaborator Author

sauk2 commented Jun 4, 2024

Minor thing about a ROS environment variable. Good to do.

Somehow the action seems to be failing now. I am going though the error right now. Let me know if you have any idea about it.

The error has been resolved. Action works!

This PR is ready to be merged 🚀

@j-rivero j-rivero merged commit 2aa0b25 into gazebo-tooling:main Jun 4, 2024
4 checks passed
@j-rivero
Copy link
Contributor

j-rivero commented Jun 4, 2024

🎉

@sauk2 sauk2 deleted the feat/linux-setup branch June 5, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sauk2 @j-rivero