Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MFC compiler tools on Windows #488

Closed
wants to merge 15 commits into from

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jul 13, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

I added qt5-winextras in ign-gui CI, but this requires MFC compiler tools. This PR install this dependency using the MSVC installer shell.

You can see the error in the CI here

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the bug Something isn't working label Jul 13, 2021
@ahcorde ahcorde requested a review from mjcarroll July 13, 2021 20:38
@ahcorde ahcorde self-assigned this Jul 13, 2021
@ahcorde ahcorde requested a review from j-rivero as a code owner July 13, 2021 20:38
@ahcorde
Copy link
Collaborator Author

ahcorde commented Jul 14, 2021

This PR gazebosim/gz-gui#250 requires to install mesa[gles2] and mesa[egl]. These two packages are not available in the configured vcpkg tag 2020.11. We should use a newer version 2021.05.12.

I think we should run a job to update the _dls_core job.

@ahcorde
Copy link
Collaborator Author

ahcorde commented Jul 22, 2021

Related gazebosim/docs#190

@j-rivero
Copy link
Contributor

This PR ignitionrobotics/ign-gui#250 requires to install mesa[gles2] and mesa[egl]. These two packages are not available in the configured vcpkg tag 2020.11. We should use a newer version 2021.05.12.

The update is going to block this PR or we can review and test it before going for the snapshot update?

@ahcorde
Copy link
Collaborator Author

ahcorde commented Jul 22, 2021

I think you can review it and merge it, if it's fine

@j-rivero
Copy link
Contributor

I think you can review it and merge it, if it's fine

It is. Can we have a test build using this branch?

@j-rivero
Copy link
Contributor

j-rivero commented Oct 6, 2021

It is. Can we have a test build using this branch?

friendly ping @ahcorde

@j-rivero
Copy link
Contributor

Please reopen if needed.

@j-rivero j-rivero closed this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants