Migrate sdformat to GitHub CI #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scpeters
reviewed
Apr 17, 2020
chapulina
reviewed
Apr 17, 2020
scpeters
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
It looks like the CI jobs are showing up on those example PR's, which is great!
I have two minor comments:
- Is it possible to show the ABI jobs in the build status as well? They didn't show up in bitbucket, but it would be nice to attach them here.
- I like the clickable links in the jenkins job descriptions that were started from bitbucket. I'll create an issue to add that so it doesn't slow down this PR.
chapulina
approved these changes
Apr 17, 2020
scpeters
added a commit
that referenced
this pull request
Apr 29, 2020
This was broken by #168 and caused gazebo_ros_pkgs jobs to create builds for every ROS distro.
j-rivero
pushed a commit
that referenced
this pull request
Apr 29, 2020
This was broken by #168 and caused gazebo_ros_pkgs jobs to create builds for every ROS distro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enable the communication from GitHub to Jenkins for all sdformat scripts.
The approach to be able to merge this and keep the rest of our CI working has been to add new DSL files postfixed with GitHub and use them while porting the different pieces (instead of changing current files). This makes this PR difficult to review for the new DSL base classes (sorry).
For the code outside of DSL the changes to generic-abi-base are conditioned to have a new global GITHUB variable on (off by default, on added in new DSL code).
TODO: the old point of contact for CI (
sdformat-ci-pr_any) is currently not working. My plan is to use for manual CI triggering and the job will spawn all platforms testing jobs without creating a PR.Testing: