Script hooks #4
Merged
Script hooks #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
This was referenced May 2, 2020
|
instead of passing the names of these scripts as variables, what if we just hard-coded the names of expected scripts (like I think it's slightly simpler that way |
scpeters
requested changes
May 4, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org>
scpeters
approved these changes
May 11, 2020
Closed
I just noticed this comment. Yeah I think it's a good idea, but now a lot of PRs using that have been merged. So I'll just leave it as is for now and ticketed #8 so we can keep it in mind for the next pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1 and also closes #2.
Two of the hooks are being used on gazebosim/sdformat#266