Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on ign-msgs 8.2 and add QML dependencies #4

Merged
merged 2 commits into from
Jan 6, 2022

Conversation

chapulina
Copy link
Contributor

@j-rivero , what do you think of adding these QML dependencies to a stable version? They're only needed by a new plugin, and they're only checked at runtime, not at compile time.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina mentioned this pull request Jan 6, 2022
7 tasks
@j-rivero
Copy link
Contributor

j-rivero commented Jan 6, 2022

they're only needed by a new plugin, and they're only checked at runtime, not at compile time.

Sounds not a hard dependency although I see them listed unconditionally in build-deps inside the control file. Are they needed during build + testing?

@chapulina
Copy link
Contributor Author

Are they needed during build + testing?

Nope, none of the QML modules are. They're just loaded at runtime. Should I remove from Build-depends? All I'd like to do is that users get these dependencies when installing ign-gui, so the new plugin works out of the box.

@j-rivero
Copy link
Contributor

j-rivero commented Jan 6, 2022

Nope, none of the QML modules are. They're just loaded at runtime. Should I remove from Build-depends?

Yep, build-dep should list build time dependencies including testing deps.

All I'd like to do is that users get these dependencies when installing ign-gui, so the new plugin works out of the box.

They are listed under the -dev package and will be installed together with it.

@chapulina chapulina merged commit 3e8ee0b into main Jan 6, 2022
@chapulina chapulina deleted the chapulina/deps6.3 branch January 6, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants