fix pushing images to docker.io #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's see if this improves things. Thanks for your contribution @snpz! |
|
@gaul Would be even better if it would work like expected, not just on my machine. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gaul.
I took me a lot of time, reading and trial and error but I've finally come up with something to fix #479 and prepare for issue #591 I created myself yesterday.
I never used Github Actions myself so I googled a bit and found out that the official action that is used to push to ghcr.io can also be used to push to docker.io without relying on regctl.
To do this one needs to pass multiple image names that are the base for building the targets to push to.
According to how the tags in the meta action are currently setup these changes resulted in 3 tags getting pushed to both ghcr.io and docker.io each time I pushed to my branch. (docker.io depending on the existence of the DOCKER_PASS secret as before)
docker.io
ghrc.io
I also put the variable that checks for presence of the secret on the top level as it made it more readable and use some never action versions in a few places. And configured caching via github actions. This cache type is still experimental but the recommended one.
I'm not contributing a lot so if I miss something that is expected please let me know.