Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to plugin #242

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Updates to plugin #242

merged 3 commits into from
Mar 18, 2024

Conversation

cstamas
Copy link
Contributor

@cstamas cstamas commented Mar 18, 2024

Changes:

  • add dependabot to GH actions as well
  • make CI run matrix on Maven to ensure it works (as prerequisite only prevents execution) and use mnvw. In general do NOT rely on Maven brought by setup-java, only as "bootstrap" Maven, control actual versions using Wrapper.
  • update Maven Wrapper to latest and use type "only script" (it is best and newest, as it merely delegates to real mvn script)
  • Update some plugins
  • update some configs to stop warnings about config deprecation
  • detach plugin "prerequisite" and "dependency", use prerequisite as wanted (3.2.5) but build against latest (3.9.6)

Rationale of that last one is:

  • be up to date regarding deprecations, recent changes in Maven Core
  • but run the build/ITs with full range of supported Maven versions, and that will catch for sure any incompatibility

@cstamas
Copy link
Contributor Author

cstamas commented Mar 18, 2024

One recommendation: prerequisite Maven version 3.2.5 is really old (10 years!). ASF Maven Core plugins are moving to prerequisite of 3.6.3, FYI.

@gaul gaul merged commit fd59551 into gaul:master Mar 18, 2024
3 checks passed
@gaul
Copy link
Owner

gaul commented Mar 18, 2024

Thank you for your contribution @cstamas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants