[gatsby-plugin-sharp] add missing gatsby-cli dependency #4118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge without review!
In #4076 I added implicit dependency on
gatsby-cli/lib/reporter
togatsby-plugin-sharp
, which would works fine when installing dependencies with yarn and not with npm.gatsby
package has listedgatsby-cli
as dependency and yarn will install bothgatsby
andgatsby-cli
in project node_modules and npm will installgatsby-cli
ingatsby
s node_modules.Propably better way would be exporting
reporter
fromgatsby
(similar togatsby-link
exported from gatsby in v2), but this would cause another conflict to resolve when merging master into v2 which I'd like to avoid.