Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why doesn't CI catch these?? #4066

Merged
merged 1 commit into from
Feb 16, 2018
Merged

Why doesn't CI catch these?? #4066

merged 1 commit into from
Feb 16, 2018

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Feb 16, 2018

No description provided.

@ghost ghost assigned jquense Feb 16, 2018
@ghost ghost added the review label Feb 16, 2018
@KyleAMathews KyleAMathews merged commit bb258cb into v2 Feb 16, 2018
@ghost ghost removed the review label Feb 16, 2018
@KyleAMathews KyleAMathews deleted the fix-dep branch February 16, 2018 00:28
@KyleAMathews
Copy link
Contributor

Need integration tests

@KyleAMathews
Copy link
Contributor

Publishing packages again.

@jquense
Copy link
Contributor Author

jquense commented Feb 16, 2018

eslint-iimport should get this tho, I'll make a note to double check on the lint CI situation...

@saurabharch saurabharch mentioned this pull request Feb 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jquense jquense

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jquense @KyleAMathews