-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show other wrapper require errors than MODULE_NOT_FOUND on console #366
Conversation
Oh so sorry about this... we'd run across this same problem elsewhere but missed fixing this one :-( Thanks for the PR! I'm sure it'll save a lot of other people trouble. The PR looks great other than an eslint error. If you could fix that, I'll get this merged and cut a new release. |
Pushed new version with lines wrapped, eslint should accept it now. |
Hmmm Travis failed again but it was a Mac timing out. They've been super flakey lately :-( Oh well... Merging, thanks! This is perfect. Thanks so much for helping make Gatsby better! |
Thanks for a great platform, it's become my default for building websites :-) |
Good to hear :-) On Sat, Jul 30, 2016 at 9:06 AM Kenneth Falck notifications@github.com
|
Hiya @kennu! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
I spent a lot of time debugging an issue caused by a wrapper JSX that tried to use
window
when server-side rendering. It was hard to identify because Gatsby quietly ignored the wrapper require errors.So I made this patch to show require errors when they are something else than "module not found". For some reason, when running Gatsby, e.code is not set to MODULE_NOT_FOUND as it should, so I also included a regex check for the message.