Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-sass): fix default output style & allow unknown options #27822

Merged
merged 2 commits into from
Nov 4, 2020
Merged

fix(gatsby-plugin-sass): fix default output style & allow unknown options #27822

merged 2 commits into from
Nov 4, 2020

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Nov 4, 2020

  • The default outputStyle cannot be "nested", as that's not supported by dart-sass
  • Since these plugin options are mainly passed through to the Sass implementation, there is a large surface area of options we support but don't know about. Mentioned in bug(gatsby-plugin-sass): plugin option issues #27796 are two, webpackImporter and cssLoader, but I'm sure there's others. In order to avoid future issues with options we don't know about, I decided to let unknown options pass through for this plugin only.

Closes #27796

@mxstbr mxstbr requested a review from a team as a code owner November 4, 2020 07:46
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 4, 2020
@LekoArts LekoArts added topic: sass and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 4, 2020
LekoArts
LekoArts approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LekoArts LekoArts merged commit decd4ff into master Nov 4, 2020
@LekoArts LekoArts deleted the sass/fix-default-output-style branch November 4, 2020 10:30
vladar pushed a commit that referenced this pull request Nov 4, 2020
@mxstbr @vladar
fix(gatsby-plugin-sass): fix default output style & allow unknown opt…
ace61b1 
…ions (#27822)

(cherry picked from commit decd4ff)
vladar pushed a commit that referenced this pull request Nov 4, 2020
@mxstbr @vladar
fix(gatsby-plugin-sass): fix default output style & allow unknown opt…
23c035d 
…ions (#27822)

(cherry picked from commit decd4ff)
@vladar vladar mentioned this pull request Nov 4, 2020
Merged
vladar added a commit that referenced this pull request Nov 4, 2020
@vladar @mxstbr
fix(gatsby-plugin-sass): fix default output style & allow unknown opt…
4ce50ac 
…ions (#27822) (#27831)

(cherry picked from commit decd4ff)

Co-authored-by: Max Stoiber <contact@mxstbr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(gatsby-plugin-sass): plugin option issues
2 participants
@mxstbr @LekoArts