-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): fix brand name -> gatsby-transformer-{cloudinary,yaml,remark} #27220
fix(docs): fix brand name -> gatsby-transformer-{cloudinary,yaml,remark} #27220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jazibjafri. Thanks for your PR.
Could you please expand this PR with a bunch of words from that dictionary, rather than just one? For example an acceptable PR would at least go through all plugins on the list and make them consistent, even double checking whether all the plugins in the monorepo are actually in there and making sure they're all spelled consistently.
I mean otherwise I might be tempted to think you're just doing the minimal effort for a certain piece of clothing. And I'm sure you really just wanted to help.
Also, please mark the words you've processed in the linked issue, as requested.
Thanks in advance!
@pvdz hey I understand, I can definitely expand this PR, but don't you think it'll be much work for review if all plugins are processed in one PR? Let me know and I'll update with adding more plugins. Thanks |
Yes, but so is a single PR for each of those changes. Probably even more so. I'll do the work if you do :) |
@pvdz I'll do it. |
@pvdz Hey, I can't edit the original issue comment to add items to that list. No option to edit is visible to me. |
@pvdz I processed PS: If I did something wrong in this PR, let me know, and I'll fix it as soon as I can. :) |
@pvdz Also, tell me what did I do that failed the checks, so I fix them too. |
…x-gatsby-transformer-cloudinary
I'm not sure how to explain this properly but the bottom line is that I don't think this is a good PR. If you look through the PR you can see that it leaves certain pages in a worst state, like when you change a header that mentions two package names and you only add backticks to one package name but not the other. I think that inconsistency is objectively a worse state than having no backticks at all. There are some other cases where I'm not sure the backticks are useful or necessary. Fwiw, I hope you got your shirt, but I am going to close this PR. |
Description
changes:
gatsby-transformer-yaml
(always in codeblocks)gatsby-transformer-remark
(always in codeblocks)Documentation
Related Issues
#25290
enhancement (docs): Improvements to retext-spell