Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blog): Bring back links in Pullquote citation #25251

Merged
merged 1 commit into from
Jun 24, 2020
Merged

chore(blog): Bring back links in Pullquote citation #25251

merged 1 commit into from
Jun 24, 2020

Conversation

fk
Copy link
Contributor

@fk fk commented Jun 24, 2020

@fk fk requested a review from mgienow June 24, 2020 11:37
@fk fk requested a review from a team as a code owner June 24, 2020 11:37
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 24, 2020
@fk fk added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 24, 2020
@fk fk mentioned this pull request Jun 24, 2020
Closed
mgienow
mgienow approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@mgienow mgienow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray 🎉!

@fk
Copy link
Contributor Author

fk commented Jun 24, 2020

Uh … I forgot the mandatory PR YouTube link: https://www.youtube.com/watch?v=ZEq7q8IMz9U

@fk
Copy link
Contributor Author

fk commented Jun 24, 2020

Booooooooooooooo 😭 😉 @sidharthachatterjee

$ remark --quiet --frail "./docs/"
 docs/blog/2020-06-22-Announcing-Gatsby-Partner-Program/index.md
   37:1  warning  Missing marker in block quote  no-blockquote-without-marker  remark-lint
   37:1  warning  Remove 1 line before node      no-consecutive-blank-lines    remark-lint
   38:1  warning  Missing marker in block quote  no-blockquote-without-marker  remark-lint
   39:1  warning  Missing marker in block quote  no-blockquote-without-marker  remark-lint
   40:1  warning  Missing marker in block quote  no-blockquote-without-marker  remark-lint
   62:1  warning  Missing marker in block quote  no-blockquote-without-marker  remark-lint
   62:1  warning  Remove 1 line before node      no-consecutive-blank-lines    remark-lint
   63:1  warning  Missing marker in block quote  no-blockquote-without-marker  remark-lint
   64:1  warning  Missing marker in block quote  no-blockquote-without-marker  remark-lint
   65:1  warning  Missing marker in block quote  no-blockquote-without-marker  remark-lint
   66:1  warning  Missing marker in block quote  no-blockquote-without-marker  remark-lint
   67:1  warning  Missing marker in block quote  no-blockquote-without-marker  remark-lint
 ⚠ 12 warnings
 error Command failed with exit code 1.
 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Unfamiliar with the linter — do you have an idea?

@sidharthachatterjee
Copy link
Contributor

@fk Same. I think @tesseralis added this linter recently!

@mgienow
Copy link
Contributor

mgienow commented Jun 24, 2020

this linter has been making my recent blog publishing life recently miserable 😹

@mgienow mgienow merged commit 30f21f6 into master Jun 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the fk/pullquote-citation-with-links-a-la-chatterjee branch June 24, 2020 12:44
fk added a commit that referenced this pull request Jun 24, 2020
@fk
Revert "chore(blog): Bring back links in Pullquote citation (#25251)"
280a477 
This reverts commit 30f21f6.
@fk fk mentioned this pull request Jun 24, 2020
Merged
@fk
Copy link
Contributor Author

fk commented Jun 25, 2020

@mgienow I reverted the changes from this PR because if we kept them in our master branch, all subsequent deploys of our website would have failed, because the linter check told us to. LMK if you have any questions — happy to chat about this more! (even though there probably are people who can explain this way better than I can)

@fk
Copy link
Contributor Author

fk commented Jun 25, 2020

FWIW, here are the two things that the parser chokes on:

@muescha
Copy link
Contributor

muescha commented Jun 30, 2020

@fk: fixed in:

@muescha muescha mentioned this pull request Jun 30, 2020
Closed
@muescha
Copy link
Contributor

muescha commented Jun 30, 2020

@mgienow

this linter has been making my recent blog publishing life recently miserable 😹

can you please describe it with details in this issue (to give you a better publishing experience):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgienow mgienow mgienow approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fk @sidharthachatterjee @mgienow @muescha