Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grouping together minor updates in renovate.json rule #18644

Merged
merged 2 commits into from
Oct 16, 2019
Merged

grouping together minor updates in renovate.json rule #18644

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c78e89b
grouping together minor updates in renovate.json rule
FailedSitcom Oct 14, 2019
c9487c0
adding rule for patch updates
FailedSitcom Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@
"bumpVersion": null,
"semanticCommitScope": null,
"prHourlyLimit": 0,
"packageRules": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add one more for patches perhaps?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe we only need to group patches and keep minors separate? What do you think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @sidharthachatterjee! I'll take a look at both options and see which might be more appropriate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidharthachatterjee I reviewed recent package updates, and whilst the vast majority of updates are patches (so definitely more important to batch), grouping together minor updates also feels like it would clear up a fair amount of noise with any major risks.

Let me know if you have any other thoughts, and thank you so much for such a helpful, welcoming introduction to contributing to Gatsby. 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree with you and this looks like a good approach!

Thank you so much for taking the time to research this and to make a thought out decision and of course for contributing back this change!

{
"groupName": "minor updates in packages",
"updateTypes": ["minor"]
}
],
"timezone": "GMT",
"schedule": "after 10am on Monday"
}