Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starters): add gatsby-starter-leaflet #18580

Merged
merged 4 commits into from
Oct 14, 2019

Conversation

colbyfayock
Copy link
Contributor

Description

  • Adds gatsby-starter-leaflet to showcase.
  • Adds new category Mapping:Leaflet - the goal is to both provide the top level category of Mapping to encourage more map submissions with a subset of Leaflet, as there are other popular Mapping frameworks available.

@colbyfayock colbyfayock requested a review from a team as a code owner October 13, 2019 23:45
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not create a specific tag for Mapping:Leaflet as it's not widely used.

@wardpeet wardpeet added the status: awaiting author response Additional information has been requested from the author label Oct 14, 2019
@colbyfayock
Copy link
Contributor Author

@wardpeet sure thing, updated it to just Mapping

@wardpeet
Copy link
Contributor

We don't want to add Mapping either 😛. Sorry about this but we don't want to add to many categories to our list. We also need to remove some that shouldn't be there.

@colbyfayock
Copy link
Contributor Author

fair enough, though I 🤞maybe it'll appear some day. it's an increasingly growing space with a lot of interesting technical work. we're building https://www.element84.com/dr/ on Gatsby for instance :)

removed from both files

@LekoArts LekoArts removed the status: awaiting author response Additional information has been requested from the author label Oct 14, 2019
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@LekoArts LekoArts merged commit 9ce5de0 into gatsbyjs:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants