Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Blogpost about improving time to interactive in gatsby-plugin-segment-js #17179

Merged
merged 21 commits into from
Oct 11, 2019
Merged

docs: Blogpost about improving time to interactive in gatsby-plugin-segment-js #17179

merged 21 commits into from
Oct 11, 2019

Conversation

Kilian
Copy link
Contributor

@Kilian Kilian commented Aug 29, 2019

Hi 👋

I got asked to write a blog post about some changes I proposed to gatsby-plugin-segment-js that improve the "time to interactive" metric: https://twitter.com/gatsbyjs/status/1166319072704901121 So here it is :)

@Kilian Kilian requested a review from a team as a code owner August 29, 2019 13:14
marcysutton
marcysutton suggested changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool post! I left some suggestions, let me know if you have any questions. And thanks for the PR!

@wardpeet wardpeet added the status: awaiting author response Additional information has been requested from the author label Sep 10, 2019
@LekoArts
Copy link
Contributor

Hi @Kilian 👋 Do you have time to implement Marcy's suggestions? Would be awesome!

Kilian and others added 9 commits September 17, 2019 05:52
@Kilian
Update docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-dela…
7a01415 
…ying-third-party-scripts/index.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@Kilian
Update docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-dela…
1f39ddd 
…ying-third-party-scripts/index.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@Kilian
Update docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-dela…
e291c86 
…ying-third-party-scripts/index.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@Kilian
Update docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-dela…
c1e22f6 
…ying-third-party-scripts/index.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@Kilian
Update docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-dela…
86f6802 
…ying-third-party-scripts/index.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@Kilian
Update docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-dela…
72eabea 
…ying-third-party-scripts/index.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@Kilian
Update docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-dela…
a49f50c 
…ying-third-party-scripts/index.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@Kilian
Update docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-dela…
89ac835 
…ying-third-party-scripts/index.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@Kilian
Update docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-dela…
5f7c46a 
…ying-third-party-scripts/index.md

Co-Authored-By: Marcy Sutton <marcy@gatsbyjs.com>
@Kilian
Copy link
Contributor Author

Kilian commented Sep 17, 2019

@marcysutton @LekoArts Just went through them!

@LekoArts LekoArts added status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response Additional information has been requested from the author labels Sep 18, 2019
wardpeet
wardpeet reviewed Oct 11, 2019
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some suggestions to change some wordings. WDYT? I can't wait to get this shipped!

docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-delaying-third-party-scripts/index.md Outdated

These together might mean that you have a website that _feels_ fast under some circumstances, but Google will give you a penalty because it's slow.

To get an overview of how your site scores, you can use Lighthouse, either in your Chrome developer tools by going to the "Audits" tab, or by going to [web.dev](https://web.dev/measure). This will test your site on a number of different metrics, such as accessibility, SEO (Search Engine Optimization), and best practices, but the one we're interested in is "performance".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is also https://developers.google.com/speed/pagespeed/insights/ if you just want performance or the chrome extension if you want the latest and greatest lighthouse. Audit panel is mostly on an outdated version.

I don't think it's necessary to point this out but just stating it in the review as other possible values.

Copy link
Contributor Author

@Kilian Kilian Oct 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah there's the CLI too etc. I think pointing people to web.dev is the best method but that's not available for all sites like localhosts or intranet pages, but the audit panel does work for those.

Kilian and others added 4 commits October 11, 2019 16:29
@Kilian @wardpeet
Update docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-dela…
f4a6de9 
…ying-third-party-scripts/index.md

Co-Authored-By: Ward Peeters <ward@coding-tech.com>
@Kilian @wardpeet
Update docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-dela…
d2ba195 
…ying-third-party-scripts/index.md

Co-Authored-By: Ward Peeters <ward@coding-tech.com>
@Kilian @wardpeet
Update docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-dela…
2d626ae 
…ying-third-party-scripts/index.md

Co-Authored-By: Ward Peeters <ward@coding-tech.com>
@Kilian @wardpeet
Update docs/blog/2019-08-30-speed-up-your-time-to-interactive-by-dela…
2f65493 
…ying-third-party-scripts/index.md

Co-Authored-By: Ward Peeters <ward@coding-tech.com>
@Kilian
Copy link
Contributor Author

Kilian commented Oct 11, 2019

@wardpeet Happy with all of them, being more clear is definitely an improvement!

@Kilian Kilian requested a review from marcysutton October 11, 2019 14:32
marcysutton
marcysutton approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool post! Thanks for writing it.

@marcysutton marcysutton merged commit 55433b4 into gatsbyjs:master Oct 11, 2019
@gatsbot
Copy link

gatsbot bot commented Oct 11, 2019

Holy buckets, @Kilian — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet left review comments

@marcysutton marcysutton marcysutton approved these changes

@amberleyromo amberleyromo Awaiting requested review from amberleyromo

Assignees
No one assigned
Labels
status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kilian @LekoArts @marcysutton @wardpeet @lannonbr