Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-transformer-remark): Add fallback when markdown doesn't include excerpt_separator #16420

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

Patouche
Copy link
Contributor

@Patouche Patouche commented Aug 7, 2019

Description

When plugin option excerpt_separator is defined and the markdown content don't have the separator, add fallback to the default truncate method.

Related Issues

Fixes #15286

When plugin option excerpt_separator is defined and the markdown content
don't have the separator, add fallback to the default truncate method

Signed-off-by: Patrick Allain <allain.pat@gmail.com>
@Patouche Patouche requested a review from a team as a code owner August 7, 2019 01:43
@lannonbr lannonbr changed the title Fix #15286 fix(gatsby-transformer-remark): Add fallback when markdown doesn't include excerpt_separator Aug 7, 2019
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you so much @Patouche 👍

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 8, 2019
@gatsbybot gatsbybot merged commit f77e233 into gatsbyjs:master Aug 8, 2019
@gatsbot
Copy link

gatsbot bot commented Aug 8, 2019

Holy buckets, @Patouche — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

excerpt(pruneLength: 120) returning entire article
3 participants