fix(gatsby-source-filesystem): Move GraphQL definition for File into sourceNodes #16041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidharthachatterjee
suggested changes
Jul 24, 2019
There was a problem hiding this comment.
I think we should move to sourceNodes for now and switch back to createSchemaCustomization once we make some progress on #16055
sidharthachatterjee
approved these changes
Jul 30, 2019
|
Yeah, probably makes sense to move into core in the long term. Publishing this for now to solve backwards compatibility for folks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #15409
gatsby-source-filesystemuses thecreateSchemaCustomizationAPI, which is only available in Gatsby ^2.12, so we should bump the peer deps.Fixes #15680