Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-transformer-remark): Fix transformer-remark when using assetPrefix #15518

Merged
merged 2 commits into from
Jul 10, 2019
Merged

fix(gatsby-transformer-remark): Fix transformer-remark when using assetPrefix #15518

merged 2 commits into from
Jul 10, 2019

Conversation

xavivars
Copy link
Contributor

@xavivars xavivars commented Jul 8, 2019

Description

Fixed support for assetPrefix with gatsby-transformer-remark

Related Issues

Fixes #15514

@xavivars xavivars requested a review from a team as a code owner July 8, 2019 15:09
@xavivars xavivars changed the title Fix remark-transformer when using assetPrefix fix(gatsby-transformer-remark): Fix transformer-remark when using assetPrefix Jul 8, 2019
@xavivars
Copy link
Contributor Author

@DSchau, you may want to look at this PR. It's a leftover of #12128

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks for doing this! 🥇

Can you create a test with a relative link too?

@wardpeet wardpeet added the status: awaiting author response Additional information has been requested from the author label Jul 10, 2019
@xavivars
Copy link
Contributor Author

@wardpeet do you mean one that doesn't start with /? Or one for the case where assetPrefix is not used?

If it's the second, the test already exists.

@wardpeet
Copy link
Contributor

first one :) so where it doens't start with / but maybe ./ or just relative my-pages/test

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it 🛳! Thanks for fixing 🙏💪

@wardpeet wardpeet merged commit 44f7550 into gatsbyjs:master Jul 10, 2019
@gatsbot
Copy link

gatsbot bot commented Jul 10, 2019

Holy buckets, @xavivars — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@pieh
Copy link
Contributor

pieh commented Jul 10, 2019

Published gatsby-transformer-remark@2.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting author response Additional information has been requested from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gatsby transformer remark doesn't work with assetPrefix
3 participants