-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-transformer-remark): Fix transformer-remark when using assetPrefix #15518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! thanks for doing this! 🥇
Can you create a test with a relative link too?
@wardpeet do you mean one that doesn't start with If it's the second, the test already exists. |
first one :) so where it doens't start with / but maybe ./ or just relative my-pages/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship it 🛳! Thanks for fixing 🙏💪
Holy buckets, @xavivars — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Published |
Description
Fixed support for
assetPrefix
withgatsby-transformer-remark
Related Issues
Fixes #15514