-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change gatsby-transformer-remark excerpt behavior #14723
Change gatsby-transformer-remark excerpt behavior #14723
Conversation
- Plain text even with separator - New format for MARKDOWN
I have no idea why some of tests are failing. |
There was a stale snapshot (happens sometimes when writing tests). I've removed it now. I'll merge it and release as a minor version update for the plugin, thanks a lot! |
Holy buckets, @riywo — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Published as |
OMG, thank you so much!!! |
Description
This commit changes
excerpt
behavior ofgatsby-transformer-remark
:Previously,
PLAIN
excerpt returns different format with/withoutexcerpt_separator
because it respectedgray-matter
'sexcerpt
(which is raw markdown) whenexcerpt_separator
is specified. Now, it applies the same logic used by without separator.To keep the current behavior somewhere, we also introduces
MARKDOWN
format. So,excerpt(format: MARKDOWN)
+excerpt_separator
is identical with the currentexcerpt(format: PLAIN)
+excerpt_separator
.Related Issues
Addresses #4459