Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call next() after serving HTML #1349

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Call next() after serving HTML #1349

merged 1 commit into from
Jul 3, 2017

Conversation

levibuzolic
Copy link
Contributor

Fixes #1348

Introduced in #1324

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 3, 2017 •
edited
Loading

Deploy preview ready!

Built with commit d20629e

https://deploy-preview-1349--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 3, 2017 •
edited
Loading

Deploy preview ready!

Built with commit d20629e

https://deploy-preview-1349--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 3, 2017 •
edited
Loading

Deploy preview ready!

Built with commit d20629e

https://deploy-preview-1349--gatsbyjs.netlify.com

@KyleAMathews
Copy link
Contributor

Does this need to be in an else? Or does calling next have no effect if you've already responded? Don't use express much :-)

@levibuzolic
Copy link
Contributor Author

Looking at the docs I think it's a no-op but will put it in an else as it seems to be the common convention.

If the current middleware function does not end the request-response cycle, it must call next() to pass control to the next middleware function. Otherwise, the request will be left hanging.

@levibuzolic
Copy link
Contributor Author

Commit updated.

@KyleAMathews
Copy link
Contributor

Thanks for the quick fix!

@KyleAMathews KyleAMathews merged commit 582d432 into gatsbyjs:1.0 Jul 3, 2017
@levibuzolic levibuzolic deleted the fix-static-timeouts branch July 3, 2017 06:01
@levibuzolic levibuzolic mentioned this pull request Jul 3, 2017
Closed
This was referenced Apr 20, 2021
Open
Open
Open
Open
Open
This was referenced Sep 8, 2021
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@levibuzolic @gatsbybot @KyleAMathews