-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0] Redux example #1081
[1.0] Redux example #1081
Conversation
Deploy preview ready! Built with commit b27a1fa |
Deploy preview ready! Built with commit b27a1fa |
Deploy preview ready! Built with commit b27a1fa |
examples/redux/src/html.js
Outdated
<meta charSet="utf-8" /> | ||
<meta | ||
name="description" | ||
content="Gatsby example site showing use with no plugins" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this and title need updated
Nice! Perfect little example. Very clear. |
Agree, great example! Thanks @scottyeck! @KyleAMathews I used this to see I could reproduce the issue I was seeing where webpack was not getting applied to I pulled the code out into a separate repo to make it easier to repro.
@KyleAMathews If it repro's for you too, I can look into a fix if you point me in the right direction. |
ahhh this very specific case is where there's trouble because Gatsby isn't running things through Babel or Webpack. Gatsby does a server render of your html.js/ssr plugins when you load a page in development gatsby/packages/gatsby/src/utils/develop.js Line 103 in 4645524
To ensure consistency with production, we should really be generating an HTML file there with https://github.com/markdalgleish/static-site-generator-webpack-plugin Right now a gatsby-ssr plugin could import a file or some other webpack-specific thing and development would break. Would be great if you could tackle that. @scottyeck on this PR — do you think you'll have a bit of time in the next day or two to push this across the finish line? |
@mericsson Yup - can confirm that we're seeing the same thing. We had to ship something ASAP, so I actually just converted all of our |
Thanks @scottyeck ! |
Deploy preview failed. Built with commit b27a1fa https://app.netlify.com/sites/using-styled-components/deploys/593875218ebdd94fe24352d3 |
Deploy preview failed. Built with commit b27a1fa https://app.netlify.com/sites/using-glamor/deploys/593875218ebdd94fe24352d0 |
Deploy preview failed. Built with commit b27a1fa https://app.netlify.com/sites/using-contentful/deploys/593875218ebdd94fe24352d6 |
Not quite sure what those netlify errors are but they don't have anything to do with this PR |
* Fixes 0-index issue with link preloader as per gatsbyjs#988 * Allowing for disabled sourcemaps * Fix bad logic * Adds redux example * Ignores children in prop type validation * Rolls back to older canary to alleviate 404 issues * Example title metadata * Separate createStore * First pass at wrapping server render body * Moves api implementation into gatsby-ssr.js * Updates metadata
Related: #1079