-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nelitfy button added to the deploy section to README for starter #24
Conversation
I really like this idea but I don't think it's ready for primetime. When you click on screen, the instructions are a bit barebones. I can see people getting confused about what's going on. Things that standout:
|
Also Yarn 17.10 is still having trouble installing Gatsby https://app.netlify.com/sites/cook-crocodile-63252/deploys/5848befd71e20a4b04e512bb Perhaps 0.18 would fix that? https://github.com/yarnpkg/yarn/releases/tag/v0.18.0 |
We are actively looking into solutions for the yarn timeouts. yarnpkg/yarn#2232 |
hey guys - any luck in resolving those yarn issues on netlify yet? |
@JPHUNTER The issue seems to be on Yarn's end but we are waiting for feedback on yarnpkg/yarn#2232. Our current workaround at the moment requires the user to do the following: At present, we auto-install your dependencies using yarn if we find yarn.lock - but it frequently hangs when the 'fsevents' (or other module not available for our architecture) is even optionally required. So you have a few choices to work around it until we (or the yarn maintainers) comes up with something permanent. Let me know if none of these work (and why) and I can try to come up with some other suggestion. don't ship us a yarn.lock and we'll use npm to install Add a .nvmrc to your repository. This will also tell any other developer using the repository which version of node it depends on. You can either set a specific version or just have a major version in the file, like the number 6 for the latest version of node 6.x This is not ideal which is why we are looking forward to hearing feedback from our open issue. |
@KyleAMathews and @JPHUNTER we are unblocked on yarn. Netlify is working on a post-modem on the issue and details on the solution to have out next week. Feel free to try out the button now. |
Sweet! Is there anyway btw, to see how many times a button is used? That'd be cool to make publically available perhaps even add it to the button itself. |
That is in our plans to do so eventually, stay tuned. |
Cool! Gatsby 1.0 will have support for themes and this would be a great
incentive for theme authors.
…On Tue, Jan 3, 2017, 2:16 PM Brian Douglas ***@***.***> wrote:
That is in our plans to do so eventually, stay tuned.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEVh1BbMa5EWVb-9aFQr3pwPQpXOCYzks5rOrqrgaJpZM4LEzVQ>
.
|
Hey Kyle, Netlify created a new deploy to netlify button, which allows the user to test out the Gatsby template without cloning and spinning up gatsby. This PR is just including a button in the README.
Can you take a look this? Any feedback on this would be greatly appreciated.