Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nelitfy button added to the deploy section to README for starter #24

Merged
merged 3 commits into from
Jan 3, 2017

Conversation

bdougie
Copy link
Contributor

@bdougie bdougie commented Dec 5, 2016

Hey Kyle, Netlify created a new deploy to netlify button, which allows the user to test out the Gatsby template without cloning and spinning up gatsby. This PR is just including a button in the README.

Can you take a look this? Any feedback on this would be greatly appreciated.

@KyleAMathews
Copy link
Contributor

I really like this idea but I don't think it's ready for primetime. When you click on screen, the instructions are a bit barebones. I can see people getting confused about what's going on. Things that standout:

  • have name of "app" you're deploying in header instead of "new site" e.g. "Create new Gatsby Starter Default site on Netlify".
  • replace "Clone gatsbyjs/gatsby-starter-default into your GitHub account." with something like "Clone gatsbyjs/gatsby-starter-default into a new repository in your GitHub account."
  • then here copy Heroku's deploy button and start building but show the build logs inline (jumping to deploy page was odd)
  • then once the build is done (or perhaps while it's building) explain how to get a local development environment setup and how when they push changes to github netlify will rebuild their site.

@KyleAMathews
Copy link
Contributor

Also Yarn 17.10 is still having trouble installing Gatsby https://app.netlify.com/sites/cook-crocodile-63252/deploys/5848befd71e20a4b04e512bb

Perhaps 0.18 would fix that? https://github.com/yarnpkg/yarn/releases/tag/v0.18.0

@bdougie
Copy link
Contributor Author

bdougie commented Dec 12, 2016

We are actively looking into solutions for the yarn timeouts. yarnpkg/yarn#2232

@J-O-H-N-P-A-U-L
Copy link

hey guys - any luck in resolving those yarn issues on netlify yet?
thanks! - jp

@bdougie
Copy link
Contributor Author

bdougie commented Dec 16, 2016

@JPHUNTER The issue seems to be on Yarn's end but we are waiting for feedback on yarnpkg/yarn#2232.

Our current workaround at the moment requires the user to do the following:

At present, we auto-install your dependencies using yarn if we find yarn.lock - but it frequently hangs when the 'fsevents' (or other module not available for our architecture) is even optionally required. So you have a few choices to work around it until we (or the yarn maintainers) comes up with something permanent. Let me know if none of these work (and why) and I can try to come up with some other suggestion.

don't ship us a yarn.lock and we'll use npm to install
If you can easily exorcise fsevents from the required list in yarn.lock (essentially - it shouldn't be mentioned on its own only as an optional dependency - there should not be a stanza in yarn.lock just about fsevents) then your build should succeed. I've yet to find a "proper" way to get into this state though - removing the dependency with yarn doesn't seem to work, though editing yarn.lock by hand can work temporarily.
pin your Node.js version to 6.9.1. You use the default (Node stable) at 6.9.2 but we have pinned a fixed version of yarn to 6.9.1 that works fine.
You can set the node version in two different ways:

Add a .nvmrc to your repository. This will also tell any other developer using the repository which version of node it depends on. You can either set a specific version or just have a major version in the file, like the number 6 for the latest version of node 6.x
Set a NODE_VERSION environment variable. You can set this either while linking the repository or afterwards from the site settings screen in our UI. The value inside can be anything you would use with nvm.

This is not ideal which is why we are looking forward to hearing feedback from our open issue.

@bdougie
Copy link
Contributor Author

bdougie commented Dec 24, 2016

@KyleAMathews and @JPHUNTER we are unblocked on yarn. Netlify is working on a post-modem on the issue and details on the solution to have out next week. Feel free to try out the button now.

Deploy to Netlify

@KyleAMathews
Copy link
Contributor

Sweet!

Is there anyway btw, to see how many times a button is used? That'd be cool to make publically available perhaps even add it to the button itself.

@KyleAMathews KyleAMathews merged commit 26f8515 into gatsbyjs:master Jan 3, 2017
@bdougie
Copy link
Contributor Author

bdougie commented Jan 3, 2017

That is in our plans to do so eventually, stay tuned.

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Jan 3, 2017 via email

thomkrupa pushed a commit to thomkrupa/gatsby-starter-default that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants