-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matrix share #369
Add matrix share #369
Conversation
Something to watch out for is that a lot of Nextcloud instances do not have pretty URLs enabled so their Matrix paths would look like Also, for the root path things, we can see if this app can also be added to the list of root allowed apps. Just need to be added here: https://github.com/nextcloud/server/blob/17e58f5056f9a0ef1620e6611091a2302fbfed14/lib/private/AppFramework/Routing/RouteConfig.php#L56-L63 |
For it to work with federation you have to either set up .well-known or an srv record or have nextcloud listen to port 8448, too, so it needs more extra setup. Setups with prefix / suffix being non-blank and a domain other than that of nextcloud are, of course, more complicated. |
082de59
to
d78a618
Compare
d78a618
to
7fdb0ea
Compare
Signed-off-by: Gary Kim <gary@garykim.dev>
6c49d8e
to
bdb9f89
Compare
If one makes the change in lib/private/AppFramework/Routing/RouteConfig.php to add 'riotchat' to the list of rootUrlApps, would it be possible to test a version of riotchat on Nextcloud that have this sharing feature? |
Also, would it be possible to make an MSC to move forward? |
😢 |
soru is not committed to merging this stuffs anymore, sorry |
As discussed, this adds the matrix share thing and renames some of the existing things to be element-specific, so that it can be a general matrix integration
As soru isn't too sure how to do all that vue stuff, she dropped her files into the
js-old
folder, so that you have a general idea what is going on.None of this is tested atm in this repo, hence the draft state ^^"