Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kubernetes dependencies to v0.26.4 #8422

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:
Update Kubernetes dependencies (especially k8s.io/client-go) from v0.26.3 to v0.26.4 to resolve panic on working with special shoots.
As a consequence the gardenlet is crashing all the time if it runs as leader.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x12e9630]

goroutine 29665 [running]:
k8s.io/client-go/discovery.convertAPIResource(...)
	/go/src/github.com/gardener/gardener/vendor/k8s.io/client-go/discovery/aggregated_discovery.go:114
k8s.io/client-go/discovery.convertAPIGroup({{{0x0, 0x0}, {0x0, 0x0}}, {{0xc0922dad20, 0x15}, {0x0, 0x0}, {0x0, 0x0}, ...}, ...})
	/go/src/github.com/gardener/gardener/vendor/k8s.io/client-go/discovery/aggregated_discovery.go:95 +0x6d0
k8s.io/client-go/discovery.SplitGroupsAndResources({{{0xc08f9f7638, 0x15}, {0xc08fb7d1e0, 0x1b}}, {{0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0}, ...}, ...})
	/go/src/github.com/gardener/gardener/vendor/k8s.io/client-go/discovery/aggregated_discovery.go:49 +0x118
k8s.io/client-go/discovery.(*DiscoveryClient).downloadAPIs(0x5555?)
	/go/src/github.com/gardener/gardener/vendor/k8s.io/client-go/discovery/discovery_client.go:328 +0x3d8
k8s.io/client-go/discovery.(*DiscoveryClient).GroupsAndMaybeResources(0x2f?)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
This fix should also be cherry-picked for the release-v1.78 branch

Release note:

Update Kubernetes dependencies (especially `k8s.io/client-go`) from `v0.26.3` to `v0.26.4` to resolve panic on working with special shoots.

@gardener-prow gardener-prow bot added area/control-plane Control plane related kind/bug Bug cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 4, 2023
@gardener-prow gardener-prow bot requested review from acumino and shafeeqes September 4, 2023 15:38
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Sep 4, 2023

LGTM label has been added.

Git tree hash: 98172de6e20d308964628ba33f5be0268e8b8fe6

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2023
@ialidzhikov
Copy link
Member

/test pull-gardener-e2e-kind-ha-single-zone-upgrade

@gardener-prow gardener-prow bot merged commit d7bb5ae into gardener:master Sep 4, 2023
@shafeeqes
Copy link
Contributor

/cherry-pick release-v1.78

@shafeeqes
Copy link
Contributor

/cherry-pick release-v1.77

@shafeeqes
Copy link
Contributor

/cherry-pick release-v1.76

@gardener-ci-robot
Copy link
Contributor

@shafeeqes: new pull request created: #8423

In response to this:

/cherry-pick release-v1.78

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-ci-robot
Copy link
Contributor

@shafeeqes: new pull request created: #8424

In response to this:

/cherry-pick release-v1.77

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-ci-robot
Copy link
Contributor

@shafeeqes: new pull request created: #8425

In response to this:

/cherry-pick release-v1.76

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MartinWeindel MartinWeindel deleted the k8s-v0.26.4 branch September 5, 2023 06:07
nickytd pushed a commit to nickytd/gardener that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Control plane related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants