Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go.mods to Go 1.21 #8376

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Update go.mods to Go 1.21 #8376

merged 2 commits into from
Aug 21, 2023

Conversation

oliver-goetz
Copy link
Member

How to categorize this PR?

/area enhancement
/kind dev-productivity

What this PR does / why we need it:
There are the first PRs introducing Go 1.21 specific functions (#8369, #8373), so we should update our go.mod accordingly.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Aug 21, 2023

@oliver-goetz: The label(s) area/enhancement, kind/dev-productivity cannot be applied, because the repository doesn't have them.

In response to this:

How to categorize this PR?

/area enhancement
/kind dev-productivity

What this PR does / why we need it:
There are the first PRs introducing Go 1.21 specific functions (#8369, #8373), so we should update our go.mod accordingly.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 21, 2023
@gardener-prow gardener-prow bot requested review from ScheererJ and timuthy August 21, 2023 06:33
@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 21, 2023
@oliver-goetz
Copy link
Member Author

/area dev-productivity
/kind enhancement

😅

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 21, 2023
ialidzhikov
ialidzhikov reviewed Aug 21, 2023
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Aug 21, 2023

LGTM label has been added.

Git tree hash: 6baab72a2efcf678e4056370a7dbad1927a0e5fd

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@timuthy
Copy link
Member

timuthy commented Aug 21, 2023

/retest-required

@gardener-prow gardener-prow bot merged commit d32bf58 into gardener:master Aug 21, 2023
nickytd pushed a commit to nickytd/gardener that referenced this pull request Sep 11, 2023
@oliver-goetz @nickytd
Update go.mods to Go 1.21 (gardener#8376)
8d2a352 
* Update `go.mod`s to Go 1.21

* Revendor
@maboehm maboehm mentioned this pull request Sep 28, 2023
Merged
@oliver-goetz oliver-goetz deleted the enh/update-go-mod-to-121 branch February 13, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

@timuthy timuthy Awaiting requested review from timuthy

Assignees

@ialidzhikov ialidzhikov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-goetz @timuthy @ialidzhikov