Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move a required dependency to the first require block, move indirect dependency to the 2nd require block #7678

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Move a required dependency to the first require block, move indirect dependency to the 2nd require block #7678

merged 1 commit into from
Mar 22, 2023

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:
While reviewing #7568 I noticed that #7093 added the github.com/fluent/fluent-operator dependency to the 2nd require block. The 2nd require block should be used for indirect dependencies, while the 1st require block - for direct dependencies.
See https://stackoverflow.com/a/69433550

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Release note:

NONE

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Mar 21, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Enhancement, improvement, extension labels Mar 21, 2023
@ialidzhikov
Copy link
Member Author

/cc @Kristian-ZH

@gardener-prow gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 21, 2023
@ialidzhikov ialidzhikov changed the title Move a required dependency to the first require block, move indirect dependency to the 2nd require block Move a required dependency to the first require block, move indirect dependency to the 2nd require block Mar 21, 2023
@gardener-prow gardener-prow bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Mar 21, 2023
@ialidzhikov ialidzhikov marked this pull request as ready for review March 22, 2023 07:41
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2023
@gardener-prow gardener-prow bot requested a review from ary1992 March 22, 2023 07:41
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Mar 22, 2023 •
edited
Loading

@ialidzhikov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-e2e-kind-ha-single-zone-upgrade 833c8b7 link false /test pull-gardener-e2e-kind-ha-single-zone-upgrade
pull-gardener-e2e-kind-upgrade 833c8b7 link false /test pull-gardener-e2e-kind-upgrade
pull-gardener-e2e-kind-ha-multi-zone-upgrade 833c8b7 link false /test pull-gardener-e2e-kind-ha-multi-zone-upgrade

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rfranzke
rfranzke reviewed Mar 22, 2023
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/milestone v1.67

@gardener-prow gardener-prow bot added this to the v1.67 milestone Mar 22, 2023
@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Mar 22, 2023

LGTM label has been added.

Git tree hash: 7e98e2c41b152f8f8464ca94834dd6045d9a4eff

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Mar 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@rfranzke
Copy link
Member

/test pull-gardener-integration

@gardener-prow gardener-prow bot merged commit f3b7aa6 into gardener:master Mar 22, 2023
@ialidzhikov ialidzhikov deleted the enh/go.mod branch March 22, 2023 11:51
andrerun pushed a commit to andrerun/gardener that referenced this pull request Jul 6, 2023
@ialidzhikov @andrerun
Move a required dependency to the first require block, move indirec…
9534c8c 
…t dependency to the 2nd `require` block (gardener#7678)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@timebertt timebertt Awaiting requested review from timebertt

@Kristian-ZH Kristian-ZH Awaiting requested review from Kristian-ZH

@ary1992 ary1992 Awaiting requested review from ary1992

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.67
Development

Successfully merging this pull request may close these issues.
2 participants
@ialidzhikov @rfranzke