Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Istio 1.17.1 #7631

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Istio 1.17.1 #7631

merged 4 commits into from
Mar 16, 2023

Conversation

axel7born
Copy link
Contributor

How to categorize this PR?

Update Istio to v1.17.1

/area networking
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Update Istio to v1.17.1

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Mar 13, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/networking Networking related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 13, 2023
@gardener-prow gardener-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 13, 2023
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2023
@axel7born
Copy link
Contributor Author

/test all

@axel7born
Copy link
Contributor Author

/test all

@axel7born
Update dashboards
fd36490 
* Add more information to the ingress-gateway dashboard (sum by
  pod/namespace)
* Add workload dashboard, to see traffic specific to to shoot.
* Minor changes to control-plane dashboard and mesh dashboard
@axel7born axel7born marked this pull request as ready for review March 15, 2023 15:51
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2023
@gardener-prow gardener-prow bot requested review from ScheererJ and timuthy March 15, 2023 15:51
@axel7born
Copy link
Contributor Author

/cc @ScheererJ @DockToFuture

@gardener-prow gardener-prow bot requested a review from DockToFuture March 15, 2023 15:52
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Mar 15, 2023

@axel7born: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-e2e-kind-ha-single-zone-upgrade fd36490 link false /test pull-gardener-e2e-kind-ha-single-zone-upgrade

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ScheererJ
ScheererJ requested changes Mar 16, 2023
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the change. Please remove the telemetry envoy filters for very old releases.

ScheererJ
ScheererJ approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Mar 16, 2023

LGTM label has been added.

Git tree hash: 0ae39a6dc9a29990c2b0df919f4bc0422e86bd9f

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Mar 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScheererJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2023
@gardener-prow gardener-prow bot merged commit 1302570 into gardener:master Mar 16, 2023
@ialidzhikov ialidzhikov mentioned this pull request Apr 4, 2023
Closed
andrerun pushed a commit to andrerun/gardener that referenced this pull request Jul 6, 2023
@axel7born @andrerun
Istio 1.17.1 (gardener#7631)
769192b 
* Update istio to 1.17.1

* Adapt tests.

* vendor istio-1.17.1

* Update dashboards

* Add more information to the ingress-gateway dashboard (sum by
  pod/namespace)
* Add workload dashboard, to see traffic specific to to shoot.
* Minor changes to control-plane dashboard and mesh dashboard
@axel7born axel7born deleted the istio-1.17.1 branch August 21, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

@shafeeqes shafeeqes Awaiting requested review from shafeeqes

@timuthy timuthy Awaiting requested review from timuthy

@DockToFuture DockToFuture Awaiting requested review from DockToFuture

Assignees

@ScheererJ ScheererJ

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking Networking related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axel7born @ScheererJ